Skip to content

OPRUN-4385: Remove marketplace index from tests #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jan 22, 2026
Merged

OPRUN-4385: Remove marketplace index from tests #598

openshift-merge-bot merged 1 commit into from
Jan 22, 2026

Conversation

@camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Jan 8, 2026 •
edited
Loading

/hold

We will only merge it when we have the green flag to do so.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2026
@camilamacedo86 camilamacedo86 changed the title WIP: Remove marketplace index WIP [OPRUN-4385] Remove marketplace index Jan 8, 2026
@camilamacedo86 camilamacedo86 changed the title WIP [OPRUN-4385] Remove marketplace index WIP OPRUN-4385: Remove marketplace index Jan 8, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 8, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2026 •
edited by openshift-ci bot
Loading

@camilamacedo86: This pull request references OPRUN-4385 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86 camilamacedo86 changed the title WIP OPRUN-4385: Remove marketplace index OPRUN-4385: Remove marketplace index Jan 8, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2026 •
edited by openshift-ci bot
Loading

@camilamacedo86: This pull request references OPRUN-4385 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

/hold

We will only merge it when we have the green flag to do so.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Jan 8, 2026

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2026
@jianzhangbjz
Copy link
Member

jianzhangbjz commented Jan 12, 2026

cc @bandrade

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Jan 20, 2026

/hold cancel

We can merge now :-)
Green flag

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2026
@bandrade
Copy link
Contributor

bandrade commented Jan 20, 2026

/label qe-approved
/verified by @bandrade

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 20, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2026 •
edited by openshift-ci bot
Loading

@camilamacedo86: This pull request references OPRUN-4385 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

/hold

We will only merge it when we have the green flag to do so.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 20, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2026

@bandrade: This PR has been marked as verified by @bandrade.

Details

In response to this:

/label qe-approved
/verified by @bandrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rashmigottipati
rashmigottipati approved these changes Jan 20, 2026
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2026
@tmshort
Copy link
Contributor

tmshort commented Jan 20, 2026 •
edited
Loading

/hold

The removal of the openshift catalogs needs to be done upstream.
You are not supposed to touch files outside of the openshift directory downstream, unless directly supported by the bumper. In this case helm/olmv1/templates/openshift-catalogs/clustercatalog-openshift-redhat-marketplace.yml needs to be deleted upstream, with updated manifests.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2026
@rashmigottipati
Copy link
Member

rashmigottipati commented Jan 20, 2026

/hold

@tmshort
Copy link
Contributor

tmshort commented Jan 20, 2026

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2026
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Jan 20, 2026

Hi @tmshort

The removal of the openshift catalogs needs to be done upstream.
You are not supposed to touch files outside of the openshift directory downstream, unless directly supported by the bumper. In this case helm/olmv1/templates/openshift-catalogs/clustercatalog-openshift-redhat-marketplace.yml needs to be deleted upstream, with updated manifests.

I see. Thank you .
The bad side is that will broken the sync so and then we need to apply the changes made here to fix it

@tmshort
Copy link
Contributor

tmshort commented Jan 21, 2026 •
edited
Loading

@camilamacedo86

The bad side is that will broken the sync so and then we need to apply the changes made here to fix it

Update this PR to just remove the tests. It should be able to successfully merge.

Then the sync PR will be regenerated. At which point, it should pass.

@tmshort tmshort mentioned this pull request Jan 21, 2026
Closed
@camilamacedo86
UPSTREAM: <carry>: Remove openshift-redhat-marketplace catalog tests
bf93190 
Removes all test references to the openshift-redhat-marketplace ClusterCatalog
which has been removed from the default catalogs.

Changes:
- Updated catalog list in olmv1-catalog.go
- Removed marketplace /v1/api/all endpoint test
- Removed marketplace /v1/api/metas endpoint test
- Removed marketplace check from QE test PolarionID:77413
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jan 22, 2026
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Jan 22, 2026

/hold cancel

We removed the markeplace from upstream
Now here we are removing the tests only

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2026
@camilamacedo86 camilamacedo86 changed the title OPRUN-4385: Remove marketplace index OPRUN-4385: Remove marketplace index from tests Jan 22, 2026
@perdasilva
Copy link
Contributor

perdasilva commented Jan 22, 2026

/approve
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

@camilamacedo86: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Jan 22, 2026

@bandrade could you please help us with this one?
Thank you

rashmigottipati
rashmigottipati approved these changes Jan 22, 2026
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, perdasilva, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bandrade
Copy link
Contributor

bandrade commented Jan 22, 2026

/label qe-approved
/verified by @bandrade

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 22, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 22, 2026

@bandrade: This PR has been marked as verified by @bandrade.

Details

In response to this:

/label qe-approved
/verified by @bandrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ac979d4 into openshift:main Jan 22, 2026
13 checks passed
@camilamacedo86 camilamacedo86 deleted the remove-marketplace branch January 22, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtfranz dtfranz Awaiting requested review from dtfranz

1 more reviewer

@rashmigottipati rashmigottipati rashmigottipati approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@perdasilva perdasilva

@rashmigottipati rashmigottipati

@tmshort tmshort

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@camilamacedo86 @openshift-ci-robot @jianzhangbjz @bandrade @tmshort @rashmigottipati @perdasilva